Rename __prepare_for_exit to __wasm_call_dtors. - #201
Merged
Conversation
This emphasizes the relationship with `__wasm_call_ctors`. Note however that while `__wasm_call_ctors` is synthesized by the linker, `__wasm_call_dtors` is still defined by libc. Static constructors are registered statically, but static destructors need to be registered dynamically so that they only run if their corresponding static constructors have run, and so that they're ordered with respect to interleaved `atexit` calls.
pchickey
approved these changes
Jun 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This emphasizes the relationship with
__wasm_call_ctors. Note howeverthat while
__wasm_call_ctorsis synthesized by the linker,__wasm_call_dtorsis still defined by libc.Static constructors are registered statically, but static destructors
need to be registered dynamically so that they only run if their
corresponding static constructors have run, and so that they're
ordered with respect to interleaved
atexitcalls.